Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Now CLI v17 #24

Closed
honzajavorek opened this issue Feb 14, 2020 · 3 comments · Fixed by #26
Closed

Support for Now CLI v17 #24

honzajavorek opened this issue Feb 14, 2020 · 3 comments · Fixed by #26
Assignees
@amondnet
Labels
Type: Feature New Feature
Milestone
v2.0.0

Comments

@honzajavorek
Copy link

Since version 17 the Now CLI is now interactive by default. It can be worked around using environment variables - vercel/vercel#3588 Perhaps this action could take these as options and set the variables.
honzajavorek added a commit to honzajavorek/honzajavorek.cz that referenced this issue Feb 14, 2020
@honzajavorek
fix deployment after upgrading to Now CLI v17
c101426 
Now CLI v17 is now interactive by default. This can be worked around
using environment variables, as noted in vercel/vercel#3588

Related issue: amondnet/now-deployment#24
Related docs: https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
@maiertech maiertech mentioned this issue Feb 17, 2020
Closed
@amondnet amondnet self-assigned this Feb 18, 2020
@amondnet amondnet added the Type: Feature New Feature label Feb 18, 2020
@amondnet amondnet mentioned this issue Feb 18, 2020
Merged
@amondnet
Copy link
Owner

amondnet commented Feb 18, 2020 •
edited
Loading

@honzajavorek @454de6e v2 released

name: deploy website
on: [pull_request]
jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: amondnet/now-deployment@v2
        with:
          zeit-token: ${{ secrets.ZEIT_TOKEN }} # Required
          now-args: '--prod' 
          now-org-id: 'YOUR_ORG' 
          now-project-id: 'YOUR_PROJECT_ID'

@thelucre
Copy link

thelucre commented Feb 18, 2020 •
edited
Loading

Hello. Thanks for the update! I'm having trouble finding the Org and Project ID values in the Now dashboard. How can these be retrieved?

Edit:
Please disregard. These values can be found in ./now/project.json after linking the project via the CLI locally.

@honzajavorek
Copy link
Author

@amondnet awesome, thanks 👍

@thelucre yup, see my comment at vercel/vercel#3588 (comment)

@amondnet amondnet modified the milestones: v2.0.1, v2.0.0 Feb 25, 2020
@amondnet amondnet mentioned this issue Feb 26, 2020
Closed
honzajavorek added a commit to honzajavorek/honzajavorek.cz that referenced this issue Mar 3, 2020
@honzajavorek
upgrade now-deployment to v2
d921e3e 
See amondnet/now-deployment#24
@honzajavorek honzajavorek mentioned this issue Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amondnet amondnet

Labels
Type: Feature New Feature
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

feat: now cli v17, add NOW_PROJECT_ID and NOW_ORG_ID env variable amondnet/now-deployment
3 participants
@honzajavorek @amondnet @thelucre