fix(PeriphDrivers): Add UART Clock Setter API for all parts using UART RevB Drivers #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32655
|
/clang-format-run |
sihyung-maxim
changed the title
Jake-Carter
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
@sihyung-maxim thanks for picking this up, I should've caught this in #1108.
Tested on the AI85 and it works.
Hopefully this new implementation makes sense, I thinks it's a little cleaner to implement against the UG tables since RevB doesn't really have a concept of which clock source is which.
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Aug 15, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an extended addon to #1108 for the UART RevB drivers. Since the parameters for the
MXC_UART_RevB_SetFrequencywere changed, the parts without these new functions did not properly set the baud rate.Only tested on ME17 so far.
Checklist Before Requesting Review