Dev ucl projectfiles #232
Merged
Dev ucl projectfiles #232
+14,736
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
suggested changes
Nov 14, 2022
| export UCL_VERSION=2.7.0 | ||
|
|
||
| # Add project's include and source paths | ||
| VPATH += ./src |
There was a problem hiding this comment.
All UCL projects in the PR are missing the source code, is this intentional because of NDA rules?
There was a problem hiding this comment.
UCL team has different work flow, example source code is used for all SDKs (MML, LP, MSDK).
It is not a good idea to keep a copy of files in here.
My purpose by this commit only centralize project files (.eclipse, makefiles...) not source code.
There was a problem hiding this comment.
Ok, where is the source code hosted?
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
ozersa
force-pushed
the
dev-ucl-projectfiles
branch
from
6da6ea7 to
5de2151
Compare
lorne-maxim
approved these changes
Nov 30, 2022
|
@Jake-Carter is there any remaining item? If not could it be merged? |
Jake-Carter
approved these changes
Dec 1, 2022
Sorry @ozersa, got buried. Approved to merge |
|
Thanks, also this PR part of this development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All UCL example build succeeded.