Series of AI85 Jira Ticket Fixes. #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/clang-format-run |
Jacob-Scheiffler
suggested changes
Feb 16, 2023
| #define MXC_I2C_FASTPLUS_SPEED 1000000 | ||
| #define MXC_I2C_HS_MODE 3400000 |
There was a problem hiding this comment.
I think these suffixes should all match. Either all end in "_SPEED" or "_MODE", dealer's choice.
There was a problem hiding this comment.
Renamed to HIGH_SPEED
| int hsLowClks, hsHiClks; | ||
|
|
||
| // Calculate the period of SCL and set up 33% duty cycle | ||
| ticksTotal = PeripheralClock / hz; | ||
| hsLowClks = (ticksTotal * 2) / 3 - 1; | ||
| hsHiClks = ticksTotal / 3 - 1; | ||
|
|
||
| printf("Periph: %d\nHz: %d\n", PeripheralClock, hz); |
There was a problem hiding this comment.
Why print? Is this leftover from debug?
| @@ -263,13 +263,15 @@ int MXC_UART_SetFlowCtrl(mxc_uart_regs_t *uart, mxc_uart_flow_t flowCtrl, int rt | |||
| MXC_GPIO_Config(&gpio_cfg_uart0_flow); | |||
| break; | |||
|
|
|||
| #if (TARGET_NUM != 78000) | |||
There was a problem hiding this comment.
Are these necessary? Looking at max78000_files.mk, I don't see uart_me17.c getting added to the list of files to compile.
Jake-Carter
approved these changes
Feb 16, 2023
| #define MXC_I2C_FASTPLUS_SPEED 1000000 | ||
| #define MXC_I2C_HS_MODE 3400000 |
Jacob-Scheiffler
approved these changes
Feb 21, 2023
Jake-Carter
pushed a commit
that referenced
this pull request
Mar 7, 2023
* [MSDK-1036] AI85/ME17: I2C2 RX/TX DMA added to Read/Write DMA functions. * [MSDK-1029] AI85: Removed unsupported UART HFC pins. * [MSDK-941] AI85: Added UART3 DMA Transaction Option. * [MSDK-941] GPIO: Reversed Interrupt Polarity for level-triggered mode. * [MSDK-1026] AI85: Added GPIO2 (LPGPIO) support. * [MSDK-1023] TMR: AI85: Save selected clock source frequencies for GetTime. * [MSDK-1035] Added I2C HS Mode support. * clang-format bot reformatting. * Requested changes: Removed leftover prints and renamed a few things. * I2C: ME17: Renamed HS_MODE to HIGH_SPEED. --------- Co-authored-by: sihyung-maxim <sihyung-maxim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.