Fix/adc #433
Merged
Fix/adc #433
+33
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCR_PCLKDIV.adcfrq is 4 bits wide however it is listed as 3 bits wide in MAX32655, MAX32680 and MAX78000 header and svd files.
MAX32680 datasheet states that the 10-bit ADC has four external inputs labelled from AIN12 to AIN15. Their corresponding channels are given as CH4 to CH7. Update the example to monitor AIN12,CH4 which is routed to JH5:4 on EvKit.
sihyung-maxim
approved these changes
Feb 21, 2023
ozersa
approved these changes
Feb 22, 2023
Jake-Carter
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Fix width of adcfrq field in peripheral clock divisor register GCR_PCLKDIV.adcfrq is 4 bits wide however it is listed as 3 bits wide in MAX32655, MAX32680 and MAX78000 header and svd files. * MSDK-944: Update ADC example to read external analog input MAX32680 datasheet states that the 10-bit ADC has four external inputs labelled from AIN12 to AIN15. Their corresponding channels are given as CH4 to CH7. Update the example to monitor AIN12,CH4 which is routed to JH5:4 on EvKit. * Fix adcfrq field in me17 and ai85 register definition files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the ADC example to read an external analog input.
According to the datasheet 10-bit ADC supports four external analog inputs.
These pins are routed to JH5 connector on the EvKit. I updated the example to read AIN12.
The adcfrq field in
GCR_PCLKDIVis four bits wide ([13:10]) so fix that too in relevant header files.