Add zbar Barcode Decoder Library #500
Conversation
Development history here: ssh://gerrit.maxim-ic.com:29418/MnS/CSS/Micros/max32570_barscan Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
There was a problem hiding this comment.
One minor change needed for the Makefile - see below.
FYI added a libinfo.json file whitelisting the MAX32570 only (149b39d). Is it supported by any other micros?
| # Export other variables needed by the peripheral driver makefile | ||
| export TARGET | ||
| export COMPILER | ||
| export TARGET_MAKEFILE |
There was a problem hiding this comment.
What does TARGET_MAKEFILE do? I don't see it defined anywhere. Can it be removed?
| export TARGET | ||
| export COMPILER | ||
| export TARGET_MAKEFILE | ||
| export PROJ_CFLAGS |
There was a problem hiding this comment.
This is dangerous and could lead to the corruption of other libraries. Exporting these variables will pass them into all other library builds. Instead of
export TARGET
export COMPILER
export TARGET_MAKEFILE
export PROJ_CFLAGS
export PROJ_LDFLAGS
export MXC_OPTIMIZE_CFLAGS
export BARCODE_DECODER_DIRI suggest explicitly passing them into the recursive rule for the library file.
Ex:
${BARCODE_BUILD_DIR}/libbarcode_decoder.a: FORCE
$(MAKE) -C ${BARCODE_DECODER_DIR} lib BUILD_DIR=${BARCODE_BUILD_DIR} TARGET=${TARGET} COMPILER=${COMPILER} PROJ_CFLAGS=${PROJ_CFLAGS} PROJ_LDFLAGS=${PROJ_LDFLAGS} MXC_OPTIMIZE_CFLAGS=${MXC_OPTIMIZE_CFLAGS} BARCODE_DECODER_DIR=${BARCODE_DECODER_DIR}
Jake-Carter
added
the
build system
Only MAX32570 for now. |
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
|
Ready to be merged. |
Migrate barcode decoder library to the GitHub space to provide flexibility to the developer and customers.
No any change applied during migration.