chore(Examples): Test examples on Rev. B production silicon for MAX32655 #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons as the template README
…s the README template
…e as the README template
…event builds for FTHR kit
… and warning messages in the README
…nd add warning messages in the README
sihyung-maxim
approved these changes
Jul 5, 2023
| @@ -14,17 +14,19 @@ Universal instructions on building, flashing, and debugging this project can be | |||
|
|
|||
| ### Project-Specific Build Notes | |||
|
|
|||
| To comply with the CoreMark rules, the only source files which are included in this example directory are the core_portme.c/.h files, the rest (including main) are located in the [Coremark](../../../Libraries/Coremark/) library. | |||
| * To comply with the CoreMark rules, the only source files which are included in this example directory are the core_portme.c/.h files, the rest (including main) are located in the [Coremark](../../../Libraries/Coremark/) library. | |||
There was a problem hiding this comment.
Very minor, but I think it should be CoreMark (it's a registered trademark). We goofed when we added the library and named it Coremark. We can't change the directory name, but we can start naming it properly going forward.
There was a problem hiding this comment.
I made a note to make that change. Since it affects multiple parts, I'll do that in a separate PR.
|
Also, I recommend merging the latest changes from main so you have the auto-labeler updates. |
sihyung-maxim
changed the title
Jacob-Scheiffler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes related to testing, debugging, and updating each of the non-BLE examples for the MAX32655 Rev. B production parts. The Flash and I2C_Playback examples each have minor bug fixes and the changes for the rest of the examples are mainly just README updates.