Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Examples): Update MAX32650 CLCD example to swap Maxim logo for ADI logo #658

Merged
merged 2 commits into from
Jul 13, 2023
Merged

feat(Examples): Update MAX32650 CLCD example to swap Maxim logo for ADI logo #658

merged 2 commits into from
Jul 13, 2023

Conversation

ronyaugustine
Copy link
Contributor

Original Example displays the Maxim logo. The ADI logo and tagline for the updated example are from the ADI logo kit found on the ADI intranet Circuit. C Bitmap array was generated using GIMP.

@sihyung-maxim sihyung-maxim added the MAX32650 Related to the MAX32650 (ME10) label Jul 11, 2023
@Jacob-Scheiffler Jacob-Scheiffler self-requested a review July 11, 2023 19:12
@github-actions github-actions bot removed the MAX32650 Related to the MAX32650 (ME10) label Jul 11, 2023
@sihyung-maxim sihyung-maxim added the MAX32650 Related to the MAX32650 (ME10) label Jul 11, 2023
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would just request that you add some instructions for generating new bitmaps to the readme

@github-actions github-actions bot removed the MAX32650 Related to the MAX32650 (ME10) label Jul 12, 2023
@ronyaugustine
Copy link
Contributor Author

Looks good. I would just request that you add some instructions for generating new bitmaps to the readme

Updated README with bitmap array generation instructions in the newest commit

Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jake-Carter Jake-Carter merged commit 3ec1088 into analogdevicesinc:main Jul 13, 2023
@ronyaugustine ronyaugustine deleted the example/clcd_adi_logo branch July 13, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants