Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Examples): Remove obsolete directories from project include paths #659

Merged
merged 1 commit into from
Jul 13, 2023
Merged

chore(Examples): Remove obsolete directories from project include paths #659

merged 1 commit into from
Jul 13, 2023

Conversation

ttmut
Copy link
Contributor

@ttmut ttmut commented Jul 11, 2023

Since PR #587 removed Libraries/Boards/${TARGET}/Include and Libraries/Boards/${TARGET}/Source directories, we may remove them from project configuration files. MAX78000 still keeps a separate Include directory so I have not removed that from MAX78000 example projects' settings.

@ttmut
Remove obsolete directories from include paths
bba6aa2 
Clean up obsolete source and include paths in project setting files.
sihyung-maxim
sihyung-maxim approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .cproject files for Eclipse look good. However, I'm not too familiar with the vscode settings.json. Jake will have to confirm that.

Jake-Carter
Jake-Carter approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ttmut. Did you do this manually, or with MSDKGen?

@ttmut
Copy link
Contributor Author

ttmut commented Jul 12, 2023

Thanks @ttmut. Did you do this manually, or with MSDKGen?

Hi Jake. I used find and sed to traverse project configuration files and remove the lines containing the obsolete paths.

@Jake-Carter Jake-Carter merged commit c1f1b61 into main Jul 13, 2023
@Jake-Carter Jake-Carter deleted the dev/example_cleanup branch July 13, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Carter Jake-Carter Jake-Carter approved these changes

@ozersa ozersa ozersa approved these changes

@sihyung-maxim sihyung-maxim sihyung-maxim approved these changes

@Jacob-Scheiffler Jacob-Scheiffler Jacob-Scheiffler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ttmut @Jake-Carter @ozersa @sihyung-maxim @Jacob-Scheiffler