-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ThirdParty): Fix Wrong Output Filename for lwIP Library #669
fix(ThirdParty): Fix Wrong Output Filename for lwIP Library #669
Conversation
This reverts commit 499982d.
else | ||
LIBRARY_VARIANT=softfp | ||
LWIP_BUILD_DIR = ${LWIP_DIR}/bin/$(MFLOAT_ABI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about making default binary location to project's build directory?
LWIP_BUILD_DIR=$(CURDIR)/build/lwIP
This may also overcome some issues about library build configuration differences. You can still keep prebuild library as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only hesitation for doing this is that it's a somewhat larger library. Since users will not typically modify the lwIP source code, it will affect build times.
I think there are some other solutions we can try to address the pre-built libraries in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested Makefile changes and LGTM.
c22557c
to
9a806ee
Compare
Thanks for your testing! |
Additionally prebuild binary shall be deleted from SDK release packet. So that these binary shall be deleted: https://github.com/Analog-Devices-MSDK/msdk/tree/main/Libraries/lwIP/bin/softfp |
Description
This PR cleans up the lwIP Makefiles to fix #665
It also adds a missing libinfo.json for the MSDKGen project generators, which should fix missing include/browse paths for the project files.
Checklist Before Requesting Review