Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ThirdParty): Fix Wrong Output Filename for lwIP Library #669

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented Jul 13, 2023

Description

This PR cleans up the lwIP Makefiles to fix #665

It also adds a missing libinfo.json for the MSDKGen project generators, which should fix missing include/browse paths for the project files.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related Github issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

else
LIBRARY_VARIANT=softfp
LWIP_BUILD_DIR = ${LWIP_DIR}/bin/$(MFLOAT_ABI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making default binary location to project's build directory?

LWIP_BUILD_DIR=$(CURDIR)/build/lwIP

This may also overcome some issues about library build configuration differences. You can still keep prebuild library as it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only hesitation for doing this is that it's a somewhat larger library. Since users will not typically modify the lwIP source code, it will affect build times.

I think there are some other solutions we can try to address the pre-built libraries in a future PR.

Copy link
Contributor

@ahmetalincak ahmetalincak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested Makefile changes and LGTM.

@Jake-Carter
Copy link
Contributor Author

I've tested Makefile changes and LGTM.

Thanks for your testing!

@ozersa
Copy link
Contributor

ozersa commented Jul 19, 2023

Additionally prebuild binary shall be deleted from SDK release packet.
During first build generating binaries for target OS will be simple and better solution instead of handling OS delta in backend.

So that these binary shall be deleted: https://github.com/Analog-Devices-MSDK/msdk/tree/main/Libraries/lwIP/bin/softfp

@Jake-Carter
Copy link
Contributor Author

Thanks @ozersa, removed in fe778bf

@Jake-Carter Jake-Carter merged commit d1795f6 into analogdevicesinc:main Jul 21, 2023
@Jake-Carter Jake-Carter deleted the fix/lwip-builds branch July 21, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lwIP Library: Build system generates wrong output when PROJECT is defined in a parent Makefile
3 participants