fix(MiscDrivers): MSDK-1240: Clear out of bounds warnings seen with GCC v13.2 #852
Conversation
ahmetalincak
force-pushed
the
fix/tft_ssd2119-warnings
branch
from
ba44aab to
a435a11
Compare
| @@ -926,10 +927,10 @@ int MXC_TFT_Init(void) | |||
| memset(&images_header, 0, sizeof(Header_images_t)); | |||
|
|
|||
| // Is there any image data to work with? | |||
| if (_bin_start_ != _bin_end_) { | |||
| if ((unsigned int *)&_bin_start_ != (unsigned int *)&_bin_end_) { | |||
There was a problem hiding this comment.
Is this cast necessary, or should this reference the first field (unsigned int offset2info_palatte) of Header_images_t instead?
There was a problem hiding this comment.
Casting is for readability purposes only. We're checking if any data inserted in this specific block.
There was a problem hiding this comment.
These casts are the opposite of "readable" and like any cast in C, carry the risk of mis-aligned accesses and access to unallocated memories.
| images_start_addr = (unsigned char *)&_bin_start_; | ||
| // set header | ||
| memcpy(&images_header, images_start_addr, sizeof(Header_images_t)); | ||
| images_header = *((Header_images_t *)&_bin_start_); |
There was a problem hiding this comment.
GCC 13.2 wants to be informed about the memory address is enough for the related memcopy operation. We're giving a struct type pointer which we claim it will not overflow with the memory copying. Actually *(&_bin_start_) is enough but I added (Header_images_t *) casting for readability.
There was a problem hiding this comment.
This does not add to readability, it reduces readability and adds the possibility of mis-aligned access, and access to unallocated memories, and incompatible data structures.
This should be
images_header = bin_start;
ahmetalincak
force-pushed
the
fix/tft_ssd2119-warnings
branch
from
5d3bc9f to
5a42cd3
Compare
Description
GCC 13.2 warning clearance for tft_ssd2119.c
In the latest compiler version, the array bounds warnings appear. This was an internal issue and I tried building MAX78000 kws20_demo example and saw warnings myself.
The changes are in: