fix(CMSIS,PeriphDrivers): Fix logic error in SYS Clock Enable/Disable functions and INRO frequency for MAX32662 #895
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilicomercan
changed the title
sihyung-maxim
approved these changes
Jan 29, 2024
sihyung-maxim
changed the title
|
Thanks for the fix. Adding this for reference - just in case. |
Jake-Carter
approved these changes
Jan 29, 2024
|
Regarding this change it will be nice if this line be updated in appropriate way.
|
|
Thanks @ozersa , I will open a new PR on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INRO/NANORING clock is 80kHz according to the UG. But, it was defined as 8kHz in system_max32662.h. See page 36 -> https://www.analog.com/media/en/technical-documentation/user-guides/max32662-ug-7640.pdf
Logic error exists related to if controls in MXC_SYS_ClockDisable and MXC_SYS_ClockEnable functions. See sys_me12.c