Add volume management to CastPlayer
#2279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
cast_volume_management
branch
from
6f2522e to
c65bd97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables volume management in the
CastPlayer. In particular, the following methods are now supported:setVolume()getVolume()isDeviceMuted()setDeviceMuted()I've also updated the
fetchDeviceInfo()method so now the max volume information is also provided.Note: I didn't do anything for the
setDeviceVolume(),increaseDeviceVolume()anddecreaseDeviceVolume()methods. Let me know if something should be done there too.Note 2: I don't have access to b/364580007 (the TODO I modified in
CastPlayer). Maybe I'm missing some information or it needs to be updated.