This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Removed 'X-Requested-With' from header defaults in angular-seed #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry to hear about the painful debugging. angular-seed tracks the stable 1.0.x branch right now, which doesn't contain this change because it's a breaking change. once 1.1.x matures into 1.2, angular-seed will be updated with it and will contain this (important) change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just spent around an hour trying to figure out how to use http get with a simple third party api. The main problem was that this pull request angular/angular.js#1454 removed the 'X-Requested-With' header from angular master but not from the bundled angular in angular-seed. I can imagine a few other people were confused as I was, not realizing that angular-seed doesn't always have the latest changes!