fix(cdk/drag-drop): avoid retaining destroyed items until next drag #30514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some logic that registers and de-registers the items on create/destroy. That logic only syncs the item with the internal `DragRef` once the next dragging starts which means that we might retain a destroyed item if another drag doesn't start. These changes switch to always syncing the list when an item is removed. I've also added some context around why things are set up as they are right now since it took a while to remember the reasoning. Fixes angular#30506.
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
andrewseguin
approved these changes
Feb 19, 2025
|
The changes were merged into the following branches: main, 19.1.x |
crisbeto
added a commit
that referenced
this pull request
Feb 19, 2025
…30514) We have some logic that registers and de-registers the items on create/destroy. That logic only syncs the item with the internal `DragRef` once the next dragging starts which means that we might retain a destroyed item if another drag doesn't start. These changes switch to always syncing the list when an item is removed. I've also added some context around why things are set up as they are right now since it took a while to remember the reasoning. Fixes #30506. (cherry picked from commit 26765a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some logic that registers and de-registers the items on create/destroy. That logic only syncs the item with the internal
DragRefonce the next dragging starts which means that we might retain a destroyed item if another drag doesn't start.These changes switch to always syncing the list when an item is removed.
I've also added some context around why things are set up as they are right now since it took a while to remember the reasoning.
Fixes #30506.