fix(multiple): remove remaining references to ComponentFactoryResolver #30569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
angular-robot
bot
added
the
detected: breaking change
Removes the remaining APIs that were referencing `ComponentFactoryResolver`. These were all placeholders since we removed the code that was passing the values along a couple major versions ago. BREAKING CHANGE: * `DialogConfig.componentFactoryResolver` has been removed. * The constructor of `DomPortalOutlet` has changed. * `ComponentPortal.componentFactoryResolver` has been removed. * The constructor signature of `ComponentPortal` has changed. * `MatDialogConfig.componentFactoryResolver` has been removed.
andrewseguin
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the remaining APIs that were referencing
ComponentFactoryResolver. These were all placeholders since we removed the code that was passing the values along a couple major versions ago.BREAKING CHANGE:
DialogConfig.componentFactoryResolverhas been removed.DomPortalOutlethas changed.ComponentPortal.componentFactoryResolverhas been removed.ComponentPortalhas changed.MatDialogConfig.componentFactoryResolverhas been removed.