fix(multiple): resolve host binding issues #30570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the following issues with host bindings that weren't caught due to a lack of type checking: * The `aria-describedby` binding on `mat-chip-listbox` was doing nothing, because the `_ariaDescribedBy` property does not exist. * The `focus` handler on `mat-chip-row` was passing an event to `_handleFocus` even though one isn't required. * `MatListOption` was referencing a private method. * `mat-sort-header` was setting an invalid value to the `_recentlyCleared` signal.
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Mar 4, 2025
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Mar 4, 2025
Resolves the following issues with host bindings that weren't caught due to a lack of type checking: * The `aria-describedby` binding on `mat-chip-listbox` was doing nothing, because the `_ariaDescribedBy` property does not exist. * The `focus` handler on `mat-chip-row` was passing an event to `_handleFocus` even though one isn't required. * `MatListOption` was referencing a private method. * `mat-sort-header` was setting an invalid value to the `_recentlyCleared` signal. (cherry picked from commit eef7d66)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 4, 2025
Fixes that the docs site deployment which broke after angular#30570.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 6, 2025
Fixes that the docs site deployment which broke after angular#30570.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 6, 2025
Fixes that the docs site deployment which broke after angular#30570.
crisbeto
added a commit
that referenced
this pull request
Mar 6, 2025
Fixes that the docs site deployment which broke after #30570.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following issues with host bindings that weren't caught due to a lack of type checking:
aria-describedbybinding onmat-chip-listboxwas doing nothing, because the_ariaDescribedByproperty does not exist.focushandler onmat-chip-rowwas passing an event to_handleFocuseven though one isn't required.MatListOptionwas referencing a private method.mat-sort-headerwas setting an invalid value to the_recentlyClearedsignal.