-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/select): close panel on detach output event #30634
fix(material/select): close panel on detach output event #30634
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
663c31b
to
fead8b4
Compare
@DavidACCarvalho can you rebase the PR against the latest |
fead8b4
to
636ce53
Compare
Hey @crisbeto, the branch is already rebased. 👍🏻 |
636ce53
to
a9ecb8d
Compare
a9ecb8d
to
38b5d23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the select.html
got reformatted again.
38b5d23
to
128a4d3
Compare
Enable detection of the detach output event on the panel of the mat-select component. This ensures that when CloseScrollStrategy is set via MAT_SELECT_SCROLL_STRATEGY, the panel correctly closes on scroll, updating the panelOpen property to false.
Fixes #30620