Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/select): close panel on detach output event #30634

Merged

Conversation

DavidACCarvalho
Copy link
Contributor

@DavidACCarvalho DavidACCarvalho commented Mar 14, 2025

Enable detection of the detach output event on the panel of the mat-select component. This ensures that when CloseScrollStrategy is set via MAT_SELECT_SCROLL_STRATEGY, the panel correctly closes on scroll, updating the panelOpen property to false.

Fixes #30620

@DavidACCarvalho DavidACCarvalho requested a review from a team as a code owner March 14, 2025 23:37
@DavidACCarvalho DavidACCarvalho requested review from crisbeto and andrewseguin and removed request for a team March 14, 2025 23:37
Copy link

google-cla bot commented Mar 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@DavidACCarvalho DavidACCarvalho force-pushed the bugfix/wrong-behaviour-mat-select branch 5 times, most recently from 663c31b to fead8b4 Compare March 15, 2025 18:16
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 17, 2025
@crisbeto crisbeto removed the request for review from andrewseguin March 17, 2025 06:01
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 17, 2025
@crisbeto
Copy link
Member

@DavidACCarvalho can you rebase the PR against the latest main branch? We had to move some things around that are conflicting when I try syncing the changes into our internal repository.

@DavidACCarvalho DavidACCarvalho force-pushed the bugfix/wrong-behaviour-mat-select branch from fead8b4 to 636ce53 Compare March 17, 2025 08:14
@DavidACCarvalho
Copy link
Contributor Author

DavidACCarvalho commented Mar 17, 2025

@DavidACCarvalho can you rebase the PR against the latest main branch? We had to move some things around that are conflicting when I try syncing the changes into our internal repository.

Hey @crisbeto, the branch is already rebased. 👍🏻

@DavidACCarvalho DavidACCarvalho force-pushed the bugfix/wrong-behaviour-mat-select branch from 636ce53 to a9ecb8d Compare March 17, 2025 16:45
@angular-robot angular-robot bot requested a review from crisbeto March 17, 2025 16:45
@DavidACCarvalho DavidACCarvalho force-pushed the bugfix/wrong-behaviour-mat-select branch from a9ecb8d to 38b5d23 Compare March 18, 2025 08:55
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the select.html got reformatted again.

@DavidACCarvalho DavidACCarvalho force-pushed the bugfix/wrong-behaviour-mat-select branch from 38b5d23 to 128a4d3 Compare March 18, 2025 10:17
@crisbeto crisbeto merged commit 688c430 into angular:main Mar 18, 2025
7 of 9 checks passed
@DavidACCarvalho DavidACCarvalho deleted the bugfix/wrong-behaviour-mat-select branch March 18, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/select target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Select): MAT_SELECT_SCROLL_STRATEGY issue
2 participants