Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/timepicker): assertion error if reopened quickly #30639

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

crisbeto
Copy link
Member

Fixes that the timepicker was throwing an error if it gets closed and reopened before change detection has had a chance to run.

Fixes #30637.

Fixes that the timepicker was throwing an error if it gets closed and reopened before change detection has had a chance to run.

Fixes angular#30637.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 17, 2025
@crisbeto crisbeto requested a review from a team as a code owner March 17, 2025 13:22
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team March 17, 2025 13:22
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 17, 2025
@crisbeto crisbeto removed the request for review from mmalerba March 17, 2025 16:06
@crisbeto crisbeto merged commit 43b0860 into angular:main Mar 17, 2025
23 of 25 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x

crisbeto added a commit that referenced this pull request Mar 17, 2025
Fixes that the timepicker was throwing an error if it gets closed and reopened before change detection has had a chance to run.

Fixes #30637.

(cherry picked from commit 43b0860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/timepicker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(timepicker): Multiple overlays and host already has a portal attached
2 participants