This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(types): webdriver typings for locators #3507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cnishina
commented
Aug 31, 2016
•
cnishina
commented
- temporarily add typings for selenium-webdriver.d.ts
- include selenium-webdriver dependency to built/index.d.ts
- add webdriver typings to locators
- update example and spec/install to not use typings.json
- spec test updated to get the tsc test to pass
- includes clang formatting fixes
cnishina
force-pushed
the
definitely_typed
branch
2 times, most recently
from
e0bceef to
8bfed21
Compare
cnishina
force-pushed
the
definitely_typed
branch
from
8bfed21 to
c2b9985
Compare
| @@ -964,9 +961,9 @@ export class ElementFinder extends WebdriverWebElement { | |||
| * @returns {ElementFinder} which resolves to whether | |||
There was a problem hiding this comment.
Can you update this comment too?
There was a problem hiding this comment.
Done. Updated comment for both isPresent and isElementPresent.
- temporarily add typings for selenium-webdriver.d.ts - include selenium-webdriver dependency to built/index.d.ts - add webdriver typings to locators - update example and spec/install to not use typings.json - spec test updated to get the tsc test to pass - includes clang formatting fixes
cnishina
force-pushed
the
definitely_typed
branch
from
c2b9985 to
f1773e0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.