feat: check environment approval #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
enhancement
SMoraisAnsys
temporarily deployed
to
no-dependabot
GitHub Actions
Inactive
SMoraisAnsys
temporarily deployed
to
no-dependabot
GitHub Actions
Inactive
SMoraisAnsys
temporarily deployed
to
no-dependabot
GitHub Actions
Inactive
SMoraisAnsys
temporarily deployed
to
no-dependabot
GitHub Actions
Inactive
jorgepiloto
previously requested changes
Apr 11, 2025
There was a problem hiding this comment.
Thanks for adding this, @SMoraisAnsys. I was wondering if we could rename this to check-environment-approval, so it fits with the rest of the check- actions.
Just requesting to add a small example before approving this.
|
Checking CICD health with dev branch, changing back to main afterward. |
SMoraisAnsys
changed the title
pyansys-ci-bot
had a problem deploying
to
dependabot
GitHub Actions
Error
This reverts commit 756bc51.
|
PR is ready |
RobPasMue
approved these changes
Apr 15, 2025
SMoraisAnsys
commented
Apr 16, 2025
SMoraisAnsys
commented
Apr 16, 2025
jorgepiloto
approved these changes
Apr 16, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent developments to add a manual approval for dependabot PR (see #751 and #774), this PR gathers the decision logic of requiring a manual approval or not.
The action allows user to specify which environment they want to use when a workflow is running because either
dependabot[bot]triggered it or the workflow is associated to a PR ofdependabot[bot]andpyansys-ci-botis the one triggering the workflow. Another input is allowed to provide a "skip" environment for other cases.Note
Currently, passing
skip-manual-check-environment: ''behaves as if no environment was defined. Therefore, no comment such as the one below appear in the PR conversation.That was tested in a1d92c8, see below