Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present/past weather groups might be using incorrect table lookups in some cases #15

Closed
aothompson opened this issue Feb 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aothompson
Copy link

Here is an example synop I'm working with:

AAXX 21121
15001 07415 32931 10103 21090 39765 42250 57020 60071 72006 82110 91155
333 10178 21073 34101 55055 00010 20003 30002 50001 60004
60035 70500 83145 81533 91008 91111
444 18031 22053

This message has a weather indicator of 7. According to the WMO Manual on Codes, this indicates present weather should be encoded using tables 4680 and 4531. However, the output for present and past weather groups when running the decoder is the following:

'present_weather': {'value': 20,
'_table': '4677',
'time_before_obs': {'value': 6, 'unit': 'h'}},
'past_weather': [{'value': 0, '_table': '4561'},
{'value': 6, '_table': '4561'}],

After running some tests with different values of the weather indicator, it looks like it is just always doing weather lookups in table 4677 and 4561 regardless of what is specified.

Also, according to the WMO Code manual, if the weather indicator is coded as 2,3,5, or 6, that would suggest the present/past weather groups are omitted. In the above message, I tried changing the indicator to these values and present/past weather groups were still being returned. Idk if this is a bug per se but I thought it was worth mentioning

@tdbabas tdbabas added the bug Something isn't working label Mar 1, 2024
tdbabas added a commit that referenced this issue Dec 23, 2024
@tdbabas
Copy link
Collaborator

tdbabas commented Dec 23, 2024

Fix applied in latest release (0.1.6)

@tdbabas tdbabas closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants