Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging configuration done within module #8

Closed
RoryPTB opened this issue Feb 16, 2023 · 1 comment
Closed

Logging configuration done within module #8

RoryPTB opened this issue Feb 16, 2023 · 1 comment
Assignees
@tdbabas
Labels
enhancement New feature or request

Comments

@RoryPTB
Copy link

RoryPTB commented Feb 16, 2023

The logging basic config is written in __init__.py, which means it conflicts with other logging configurations when using the module. Preferably the logging basic config should be written in whatever code is using pymetdecoder, not hard coded in the module itself.
@tdbabas tdbabas added the enhancement New feature or request label Feb 16, 2023
@tdbabas tdbabas self-assigned this Feb 16, 2023
tdbabas added a commit that referenced this issue Apr 17, 2023
@tdbabas
removed logging configuration from module (#8)
160d9f9
@tdbabas
Copy link
Collaborator

tdbabas commented Apr 17, 2023

Hi @RoryPTB

I've removed this logging configuration now and pushed the latest version to PyPI

@tdbabas tdbabas closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdbabas tdbabas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdbabas @RoryPTB