-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) 回归散点图增加显示回归拟合函数相关配置,close #3474 #3476
Conversation
attrs: { | ||
...defaulTextStyle, | ||
...textStyle, | ||
text: equation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@visiky 看看默认的公示放到哪里比较合适。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句话的意思,能详细说一下吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equation 文本默认放置的位置在哪里?目前是在 [0, 0] 位置吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前是基于左上角给了x=20,y=20的偏移量,用户可以自定义x、y值
这个功能在 G2 5.0 会以组合 mark 的形式实现,在 G2Plot 中把拟合函数作为图表的一个特性挺好的,直接内置到散点图中~ 公式展示位置,尽量还是希望可以统一:支持相对定位和绝对定位
|
1 - 目前PR的实现方式对G2v5版本是否合适? |
我晚些再回复哈 |
1、相对定位,即标注和折线图的位置是相对的,效果如 Echarts 和 G2 5.0 版本 |
👌,对于这个PR还需要那些地方要修改吗? |
非常感谢你的提交~ 完整 PR 我看了,基于现状的 PR 内容,问题不大,可以按照这个形式。下面是一些小的问题,仅供参考: |
问题2,已经修改完毕,移除对函数的支持。 |
Any update? |
PR includes
Screenshot