Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SO_REUSEPORT #2

Closed
wants to merge 8,285 commits into from
Closed

Add support for SO_REUSEPORT #2

wants to merge 8,285 commits into from

Conversation

polachok
Copy link

Supported on Linux & *BSD

Stefan Fritsch and others added 30 commits March 23, 2013 16:04
change pool debugging messages to be unique
2cc91ed 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460180 13f79535-47bb-0310-9956-ffa450edef68
Add apr_pool_owner_set function to allow use of pool debugging with t…
f317bbe 
…hreads

Actually this function has been mentioned in the docs for over 10 years
but has never been implemented.

Also consistently destroy the thread's pool when it exits normally, not only
on apr_thread_exit(). This was already done on OS2.

Other platforms than unix are untested.



git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460182 13f79535-47bb-0310-9956-ffa450edef68
thread_pool/reslist: take ownership of the pool when we lock the mutex
ef3564f 
(except in cases where there is no chance that the pool is used)



git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460183 13f79535-47bb-0310-9956-ffa450edef68
Split apr_pool_check_integrity() into two parts
be14984 
Run the pool owner check part only after pre-cleanups have been run, in
order to give them a chance to kill of any threads that may still be
accessing the pool.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460184 13f79535-47bb-0310-9956-ffa450edef68
kill the threads in the thread pool in a pre-cleanup
a1a90ef 
This makes sure that the threads are killed when we start destroying
any sub-pools they may be using.

This is the last missing part to make the test suite run successfully with
full pool debugging enabled.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460185 13f79535-47bb-0310-9956-ffa450edef68
Add CHANGES entry for pool debugging fixes
8b79372 
PR: 43375, 52785


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460186 13f79535-47bb-0310-9956-ffa450edef68
add a warning about thread safety
b0adb11 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460241 13f79535-47bb-0310-9956-ffa450edef68
use heap memory for crypt in apr_password_validate, to reduce stack u…
7ae9898 
…sage

PR: 54572


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460243 13f79535-47bb-0310-9956-ffa450edef68
speed-up md5 by avoiding some memcopies
c83a0e6 
    
PR: 49011
Submitted by: Stefan Fritsch, Stefan Fuhrmann <stefanfuhrmann alice-dsl de>


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460244 13f79535-47bb-0310-9956-ffa450edef68
remove some backported items
966aefc 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460375 13f79535-47bb-0310-9956-ffa450edef68
@trawick
clean up a bit of error handling just to get rid of
f421a00 
  sockperf.c: In function 'main':
  sockperf.c:206:18: warning: variable 'rv' set but not used [-Wunused-but-set-variable]


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460399 13f79535-47bb-0310-9956-ffa450edef68
@trawick
hide an unused variable on Unix
1bfec25 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1460405 13f79535-47bb-0310-9956-ffa450edef68
reformat&comment char tables as preparation to add more bits
18a2cdc 
no code change


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462219 13f79535-47bb-0310-9956-ffa450edef68
apr_uri_parse(): Do not accept invalid characters in the scheme.
de6f538 
Per RFC 3986 3.3, enforce that the first segment of a relative path does
not contain a colon.

PR: 52479


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462224 13f79535-47bb-0310-9956-ffa450edef68
@rainerjung
Remove backported item.
3a19dd5 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462462 13f79535-47bb-0310-9956-ffa450edef68
remove another backported item
1ff6b12 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462559 13f79535-47bb-0310-9956-ffa450edef68
@rainerjung
Fix comment in Windows Makefile.
a92052a 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462738 13f79535-47bb-0310-9956-ffa450edef68
Copy the data folder too for testing on NetWare.
b398a43 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462769 13f79535-47bb-0310-9956-ffa450edef68
Mark apr_dbd_freetds as unsupported and remove it from all builds
54e806b 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462772 13f79535-47bb-0310-9956-ffa450edef68
@trawick
spelling fix
8974739 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1462813 13f79535-47bb-0310-9956-ffa450edef68
Fix PPC atomics to work with gcc 4.0
8349e9d 
PR: 54840
Submitted by: Mattias Engdegård <mattiase acm org>


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1470186 13f79535-47bb-0310-9956-ffa450edef68
Fix amd64 assembler version of apr_atomic_xchgptr()
0251172 
PR: 51851
Submitted by: Mattias Engdegård <mattiase acm org>


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1470348 13f79535-47bb-0310-9956-ffa450edef68
@rainerjung
Update config.guess and config.sub from
b864015 
http://git.savannah.gnu.org/cgit/config.git.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1476533 13f79535-47bb-0310-9956-ffa450edef68
remove a few backported items
8d0398b 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1477871 13f79535-47bb-0310-9956-ffa450edef68
Make sure apr_sockaddr_info_get() returns an error if
a7633b4 
- getaddrinfo() returned only useless entries
- getaddrinfo() returned EAI_SYSTEM but errno == 0
- gethostbyname() returns no error but an empty address list

Submitted by:  Jan Kaluža <jkaluza redhat com>, Stefan Fritsch


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1478905 13f79535-47bb-0310-9956-ffa450edef68
Fix invalid free when destroying pools created with
778a277 
apr_pool_create_unmanaged_ex()

PR: 54892
Submitted by: Valeriy V. Argunov <hzdbyte gmail com>


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1478934 13f79535-47bb-0310-9956-ffa450edef68
Trick autoconf into printing the correct default prefix in the help
ff9af50 
The defaults of some dirs like libexecdir are still not printed correctly,
though.

PR: 54032


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1478954 13f79535-47bb-0310-9956-ffa450edef68
Fix forever loop on NetWare when trying to get parent pool.
7b0d402 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1479836 13f79535-47bb-0310-9956-ffa450edef68
Followup fix for incomplete patch with r1479836.
6d95d48 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1479853 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
Add the apr_table_getm() call, which transparently handles the
78a7531 
merging of keys with multiple values.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1480067 13f79535-47bb-0310-9956-ffa450edef68
Guenter Knauf and others added 25 commits July 16, 2014 15:23
Fixed type; fixed comments.
afa73db 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611046 13f79535-47bb-0310-9956-ffa450edef68
Fixed indent - no code change.
55eb805 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611050 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
We do not garantee zero-ed memory for apr_skiplist_alloc(), neither in
76dff85 
the description, nor in the code for reused chunks.

So always allocate raw memory and don't rely on zero-ed one after internal
calls to apr_skiplist_alloc().


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611107 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Improve skiplist tests.
8c9adcc 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611110 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Use apr_skiplist_add() instead of apr_skiplist_insert() to merge skip…
e0e56f5 
…lists

since doublons need to be merged too.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611117 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Call free() on the skiplist structure in apr_skiplist_destroy() if it…
4e3cfa3 
… was

apr_skiplist_init()ialized without a pool (ie. malloc()ed).


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611120 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Let apr_skiplist_find_compare() handle given NULL iterator, and be safe
2fa2768 
from NULL returns.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611125 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Reuse the skiplist's stack needed by insert_compare() by growing it w…
9c9a7a9 
…ith adds.

Rename the "replace" argument as "add" (negating the boolean) to avoid confusion
since the skiplist never replaces any element (add or preserve semantic).


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611184 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Don't grow the skiplist's height if the element is finally not insert…
ffe5732 
…ed (preserve semantic).

Do this by moving the top node creation after insertion occured, and linking to the just
inserted node(s).


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611193 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Follow up to r1611193: update the inserted node's top while looping s…
e07a88c 
…hould we

have to create more than one top node (eg. preheight > 0).

(the check on p != NULL can be omited since it can't be here).


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611466 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Provide apr_skiplist_size/height/preheight() to get the corresponding…
4235d8d 
… values

in O(1), and apr_skiplist_set_preheight() to configure preheight mode.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611515 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Follow up to r1611515: remove useless <limits.h> inclusion (for unuse…
22df06e 
…d INT_MAX).

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1611517 13f79535-47bb-0310-9956-ffa450edef68
NetWare build fixes.
5ebf533 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1613086 13f79535-47bb-0310-9956-ffa450edef68
Some more NetWare build fixes.
8200044 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1613114 13f79535-47bb-0310-9956-ffa450edef68
@trawick
Fix Android compile error caused by assumption that crypt is available.
105e72c 
PR: 56627
Submitted by: Fredrik Fornwall <fredrik fornwall.net>, trawick


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1618843 13f79535-47bb-0310-9956-ffa450edef68
@trawick
apr_crypto_get_driver(): Fix invalid storage reference
f1d2e7f 
on error path.

Submitted by: Philip Martin <philip.martin wandisco.com>
Reviewed by: trawick


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1619438 13f79535-47bb-0310-9956-ffa450edef68
Fix NetWare build: set NLM version with commandline option
643e42e 
instead of linker def file due to bug with mwldnlm linker
where patch version > 26 is ignored from def file.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1621593 13f79535-47bb-0310-9956-ffa450edef68
@trawick
Follow up to r1604596: include skiplist test in the cmake-based build
045f134 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1625173 13f79535-47bb-0310-9956-ffa450edef68
@trawick
cmake >= 2.8.12 doesn't generate .pdb files for static libs,
13e61ef 
and points out that they aren't useful anyway:

  http://public.kitware.com/Bug/view.php?id=14600

remove .pdb handling for static libs regardless of cmake version


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1625175 13f79535-47bb-0310-9956-ffa450edef68
@trawick
MySQL driver: Fix incorrect check for bad parameter in the
34585f3 
driver support for apr_dbd_transaction_end().

PR: 56330
Submitted by: Weiqiang Li <weiqiang_li hotmail.com>


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1625247 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
apr_crypto_nss: Explicitly declare key sizes when using NSS. Not all …
8c43d9e 
…versions

of NSS detect key sizes correctly, leading to test failures.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1626561 13f79535-47bb-0310-9956-ffa450edef68
@rainerjung
Update config.guess and config.sub from
23c13a2 
http://git.savannah.gnu.org/cgit/config.git.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1626564 13f79535-47bb-0310-9956-ffa450edef68
The better way
31c64f6 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1626658 13f79535-47bb-0310-9956-ffa450edef68
@covener
*) On z/OS, apr_sockaddr_info_get() with family == APR_UNSPEC was not
4ea9d62 
     returning IPv4 addresses if any IPv6 addresses were returned. 
     [Eric Covener]




git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1634615 13f79535-47bb-0310-9956-ffa450edef68
Add support for SO_REUSEPORT
08e80b7 
 Supported on Linux & *BSD
@asfgit asfgit closed this Aug 16, 2015
asfgit pushed a commit that referenced this pull request Dec 16, 2020
@ylavic
Merge r1883750 from trunk:
2b85c17 
apr_pools: lock parent pool in pool_destroy_debug().

By using apr_pool_clear_debug() instead of pool_clear_debug() in
pool_destroy_debug() we gain the locking provided by the former and thus
protection from concurrent access from apr_pool_walk_tree(), which is
undefined behaviour.

While pool_destroy_debug()=>apr_pool_clear_debug()=>pool_clear_debug() calls
pool_destroy_debug() for all the children pools, this does not cause a deadlock
because apr_pool_clear_debug() locks the parent pool only (not the pool itself)
and thus pool_destroy_debug(pool->child) locks the current pool with no issue.

This fixes use-after-free like the below in httpd (with -D APR_POOL_DEBUG):

=================================================================
==2026856==ERROR: AddressSanitizer: heap-use-after-free on address 0x60600025acf0 at pc 0x7fe738f4c5be bp 0x7fe718598110 sp 0x7fe718598108
READ of size 8 at 0x60600025acf0 thread T51
    #0 0x7fe738f4c5bd in apr_thread_mutex_lock locks/unix/thread_mutex.c:124
    #1 0x7fe738f4e01c in apr_pool_walk_tree memory/unix/apr_pools.c:1505
    #2 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #3 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #4 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #5 0x7fe738f5027c in apr_pool_find memory/unix/apr_pools.c:2291
    #6 0x7fe738f14aba in apr_table_mergen tables/apr_tables.c:746
    #7 0x5578ad926a25 in ap_set_keepalive /home/ylavic/src/apache/httpd/trunk/modules/http/http_protocol.c:309
    #8 0x5578ad93933f in ap_http_header_filter /home/ylavic/src/apache/httpd/trunk/modules/http/http_filters.c:1376
    #9 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #10 0x5578ad9a67f3 in ap_content_length_filter /home/ylavic/src/apache/httpd/trunk/server/protocol.c:2046
    #11 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #12 0x5578ad9405ae in ap_byterange_filter /home/ylavic/src/apache/httpd/trunk/modules/http/byterange_filter.c:463
    #13 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #14 0x7fe7330e398b in ap_headers_output_filter /home/ylavic/src/apache/httpd/trunk/modules/metadata/mod_headers.c:891
    #15 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #16 0x7fe732e32dba in session_output_filter /home/ylavic/src/apache/httpd/trunk/modules/session/mod_session.c:501
    #17 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #18 0x5578ad9c8ee5 in default_handler /home/ylavic/src/apache/httpd/trunk/server/core.c:5188
    #19 0x5578ad9431bb in ap_run_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:170
    #20 0x5578ad944941 in ap_invoke_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:444
    #21 0x5578ad92cc23 in ap_process_async_request /home/ylavic/src/apache/httpd/trunk/modules/http/http_request.c:463
    #22 0x5578ad924d7c in ap_process_http_async_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:158
    #23 0x5578ad925410 in ap_process_http_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:252
    #24 0x5578ad97e04d in ap_run_process_connection /home/ylavic/src/apache/httpd/trunk/server/connection.c:42
    #25 0x7fe735c7ef79 in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1097
    #26 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #27 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #28 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477
    #29 0x7fe738d6ed4e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xfdd4e)

0x60600025acf0 is located 48 bytes inside of 64-byte region [0x60600025acc0,0x60600025ad00)
freed by thread T63 here:
    #0 0x7fe7391ed277 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107277)
    #1 0x7fe738f4e9e5 in pool_clear_debug memory/unix/apr_pools.c:1893
    #2 0x7fe738f4ecb2 in pool_destroy_debug memory/unix/apr_pools.c:1956
    #3 0x7fe738f4eeeb in apr_pool_destroy_debug memory/unix/apr_pools.c:2002
    #4 0x5578ada2534b in ap_queue_info_push_pool /home/ylavic/src/apache/httpd/trunk/server/mpm_fdqueue.c:230
    #5 0x7fe735c81412 in process_lingering_close /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1686
    #6 0x7fe735c7f9bc in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1255
    #7 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #8 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #9 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x@1883751 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Dec 16, 2020
@ylavic
apr_pools: lock parent pool in pool_destroy_debug().
94d2e04 
By using apr_pool_clear_debug() instead of pool_clear_debug() in
pool_destroy_debug() we gain the locking provided by the former and thus
protection from concurrent access from apr_pool_walk_tree(), which is
undefined behaviour.

While pool_destroy_debug()=>apr_pool_clear_debug()=>pool_clear_debug() calls
pool_destroy_debug() for all the children pools, this does not cause a deadlock
because apr_pool_clear_debug() locks the parent pool only (not the pool itself)
and thus pool_destroy_debug(pool->child) locks the current pool with no issue.

This fixes use-after-free like the below in httpd (with -D APR_POOL_DEBUG):

=================================================================
==2026856==ERROR: AddressSanitizer: heap-use-after-free on address 0x60600025acf0 at pc 0x7fe738f4c5be bp 0x7fe718598110 sp 0x7fe718598108
READ of size 8 at 0x60600025acf0 thread T51
    #0 0x7fe738f4c5bd in apr_thread_mutex_lock locks/unix/thread_mutex.c:124
    #1 0x7fe738f4e01c in apr_pool_walk_tree memory/unix/apr_pools.c:1505
    #2 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #3 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #4 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #5 0x7fe738f5027c in apr_pool_find memory/unix/apr_pools.c:2291
    #6 0x7fe738f14aba in apr_table_mergen tables/apr_tables.c:746
    #7 0x5578ad926a25 in ap_set_keepalive /home/ylavic/src/apache/httpd/trunk/modules/http/http_protocol.c:309
    #8 0x5578ad93933f in ap_http_header_filter /home/ylavic/src/apache/httpd/trunk/modules/http/http_filters.c:1376
    #9 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #10 0x5578ad9a67f3 in ap_content_length_filter /home/ylavic/src/apache/httpd/trunk/server/protocol.c:2046
    #11 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #12 0x5578ad9405ae in ap_byterange_filter /home/ylavic/src/apache/httpd/trunk/modules/http/byterange_filter.c:463
    #13 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #14 0x7fe7330e398b in ap_headers_output_filter /home/ylavic/src/apache/httpd/trunk/modules/metadata/mod_headers.c:891
    #15 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #16 0x7fe732e32dba in session_output_filter /home/ylavic/src/apache/httpd/trunk/modules/session/mod_session.c:501
    #17 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #18 0x5578ad9c8ee5 in default_handler /home/ylavic/src/apache/httpd/trunk/server/core.c:5188
    #19 0x5578ad9431bb in ap_run_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:170
    #20 0x5578ad944941 in ap_invoke_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:444
    #21 0x5578ad92cc23 in ap_process_async_request /home/ylavic/src/apache/httpd/trunk/modules/http/http_request.c:463
    #22 0x5578ad924d7c in ap_process_http_async_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:158
    #23 0x5578ad925410 in ap_process_http_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:252
    #24 0x5578ad97e04d in ap_run_process_connection /home/ylavic/src/apache/httpd/trunk/server/connection.c:42
    #25 0x7fe735c7ef79 in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1097
    #26 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #27 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #28 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477
    #29 0x7fe738d6ed4e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xfdd4e)

0x60600025acf0 is located 48 bytes inside of 64-byte region [0x60600025acc0,0x60600025ad00)
freed by thread T63 here:
    #0 0x7fe7391ed277 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107277)
    #1 0x7fe738f4e9e5 in pool_clear_debug memory/unix/apr_pools.c:1893
    #2 0x7fe738f4ecb2 in pool_destroy_debug memory/unix/apr_pools.c:1956
    #3 0x7fe738f4eeeb in apr_pool_destroy_debug memory/unix/apr_pools.c:2002
    #4 0x5578ada2534b in ap_queue_info_push_pool /home/ylavic/src/apache/httpd/trunk/server/mpm_fdqueue.c:230
    #5 0x7fe735c81412 in process_lingering_close /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1686
    #6 0x7fe735c7f9bc in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1255
    #7 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #8 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #9 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1883750 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Sep 10, 2021
@ylavic
apr_crypto: fix potential memory leaks of cprng_stream_ctx_t.
398fc32 
This can happen in cprng_stream_ctx_make() on error paths, or at thread exit
with APR_CRYPTO_PRNG_PER_THREAD like the below.

Direct leak of 64 byte(s) in 8 object(s) allocated from:
    #0 0x7efd954c7628 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107628)
    #1 0x7efd921db6ca  (<unknown module>)
    #2 0x7efd952937a2 in apr_crypto_prng_create crypto/apr_crypto_prng.c:367
    #3 0x7efd95292c1e in apr_crypto_random_thread_bytes crypto/apr_crypto_prng.c:218
    #4 0x5611dbbb9440 in thread_func /home/yle/src/apache/apr/trunk.ro/test/testcrypto.c:2597
    #5 0x7efd9537dd86 in dummy_worker threadproc/unix/thread.c:148
    #6 0x7efd951efea6 in start_thread nptl/pthread_create.c:477



git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1893201 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.