Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1900][FOLLOWUP] push celeborn docker image #3174

Closed

Conversation

jesusch
Copy link
Contributor

@jesusch jesusch commented Mar 25, 2025

What changes were proposed in this pull request?

the workflow was just building the images, but not pushing

Why are the changes needed?

images are now also pushed

Does this PR introduce any user-facing change?

no

How was this patch tested?

not yet

Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Merged into main(v0.6.0).

@FMX FMX changed the title [CELEBORN-1900][FOLLOWUP] we should actually push the image once it's build [CELEBORN-1900][FOLLOWUP] push celeborn docker image Mar 31, 2025
@FMX FMX closed this in 3038942 Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants