Use special domains for replication tests #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fryjordan
approved these changes
Feb 24, 2025
Per RFC6761, these special domain names are reserved which guarantees CI or local runs won't be sending network requests for these test URLs.
Antonio-Maranhao
force-pushed
the
use-special-domain-names-for-replication-tests
branch
from
de4ed51 to
9eec8fc
Compare
Antonio-Maranhao
deleted the
use-special-domain-names-for-replication-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per RFC6761, these special domain names are reserved which guarantees CI or local runs won't be sending network requests for these test URLs.
Testing recommendations
Nightwatch tests run by CI should pass
GitHub issue number
n/a
Related Pull Requests
n/a
Checklist