Skip to content

bump sql-parser 0.25 #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2022
Merged

bump sql-parser 0.25 #3698

merged 3 commits into from
Oct 4, 2022

Conversation

xudong963
Copy link
Member

Which issue does this PR close?

Closes #3697

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Oct 4, 2022
@xudong963 xudong963 requested a review from alamb October 4, 2022 09:19
@xudong963
Copy link
Member Author

cc @waitingkuo

@alamb
Copy link
Contributor

alamb commented Oct 4, 2022

The CI is failing with


failures:

---- datasource::file_format::parquet::tests::test_read_parquet_page_index stdout ----
thread 'datasource::file_format::parquet::tests::test_read_parquet_page_index' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }', datafusion\core\src\datasource\file_format\parquet.rs:1139:43
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It looks like this PR inadvertently has some changes to the submodules like parquet-testing

@alamb
Copy link
Contributor

alamb commented Oct 4, 2022

I took the liberty of reverting the submodule pins in 180e567

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xudong963

TimeUnit::Nanosecond,
Some("UTC".into()),
)),
SQLDataType::Timestamp(tz_info) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xudong963
Copy link
Member Author

I took the liberty of reverting the submodule pins in 180e567

Thanks @alamb ! Let's merge.

@xudong963 xudong963 merged commit a07bebc into apache:master Oct 4, 2022
@xudong963 xudong963 deleted the bump_sql_parser branch October 4, 2022 14:30
@ursabot
Copy link

ursabot commented Oct 4, 2022

Benchmark runs are scheduled for baseline = 5731228 and contender = a07bebc. a07bebc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@waitingkuo
Copy link
Contributor

i fired a ticket for this #3715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants