Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dead link fix #218

Closed
wants to merge 4 commits into from
Closed

dead link fix #218

wants to merge 4 commits into from

Conversation

techyang
Copy link
Contributor

What is the purpose of the change

dead link fix

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Test your code locally by running docsite start, and make sure it works as expected.
  • Make sure no files under build directory is added.
  • If this contribution is large, please follow the Software Donation Guide.

Sorry, something went wrong.

yangwenlong and others added 4 commits December 22, 2018 10:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
sync asf-site
Copy link

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please don't update html files, they are generated automatically.

@ralf0131
Copy link

ralf0131 commented Jan 5, 2019

Hi, sorry but would you please take a look at the comments I left?

@techyang
Copy link
Contributor Author

techyang commented Jan 7, 2019

Hi, sorry but would you please take a look at the comments I left?
Ok,I got it. I will commit a pr later. thank you .

@code4wt
Copy link
Contributor

code4wt commented Jan 7, 2019

issue #215 has a number of dead chains summarized, it is recommended to fix it at one time, otherwise you have to submit a lot of pull requests to complete the repair.

issue #215 中汇总了多条死链,建议一次性修复,不然要提交很多个 pull request 才能完成修复。

@techyang
Copy link
Contributor Author

techyang commented Jan 7, 2019

I'll fix one dead link and commit a pr , if it passed, I'll commit the others at one time.

@techyang techyang closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants