-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in dubbo2.7, org.apache.dubbo.samples.generic.GenericProvider execute correctly, but close server throw exception #3218
Comments
代码的逻辑的入口,参考:org.apache.dubbo.config.DubboShutdownHook#doDestroy。
执行org.apache.dubbo.config.DubboShutdownHook.destroyProtocols之前,已经执行了AbstractRegistryFactory.destroyAll(), 这个方法里已经去执行了zookeeperClient的close方法。参考:org.apache.dubbo.registry.zookeeper.ZookeeperRegistry#destroy
|
cvictory
added a commit
to cvictory/dubbo
that referenced
this issue
Jan 14, 2019
… sharing zookeeper connection, it should judge zookeeperClient.isConnected()
beiwei30
pushed a commit
that referenced
this issue
Jan 14, 2019
#3182) * fix #3179. Make registry, configcenter, matadata-report share a zookeeper connection * fix #3179. optimize registry, configcenter, matadata-report share a zookeeper connection * fix #3179. add licence * fix some review issue: just optimize constuctor order and refactor some code * modify HashMap to ConcurrentHashMap * add some comments * remove ZookeeperClientData and originalURLs * remove ZookeeperClientData and originalURLs * fix #3205 . add group into MetadataReport * remove SOURCE_URL_KEY from Constants * fix #3179 , #3205, #3218. modify review issue; when sharing zookeeper connection, it should judge zookeeperClient.isConnected()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: