[Dubbo-#1293][Baiji-9]fix the issue #1293 #2357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlong123321
changed the title
shenlong123321
changed the title
shenlong123321
changed the title
shenlong123321
changed the title
diecui1202
reviewed
Aug 29, 2018
| @@ -149,5 +202,6 @@ public String toString() { | |||
|
|
|||
| public static interface KeyGenerator { | |||
| String generateKey(ReferenceConfig<?> referenceConfig); | |||
| String generateKey(String version,String url,String name); | |||
There was a problem hiding this comment.
Why the parameters are version, url and name? not interfaceName, group and version?
diecui1202
reviewed
Aug 29, 2018
| }; | ||
| static final ConcurrentMap<String, ReferenceConfigCache> cacheHolder = new ConcurrentHashMap<String, ReferenceConfigCache>(); | ||
| private final String name; | ||
| private final KeyGenerator generator; | ||
| ConcurrentMap<String, ReferenceConfig<?>> cache = new ConcurrentHashMap<String, ReferenceConfig<?>>(); | ||
|
|
||
| //存储自定以字段到ReferenceConfig的映射 |
diecui1202
reviewed
Aug 29, 2018
| @@ -115,12 +130,50 @@ public static ReferenceConfigCache getCache(String name, KeyGenerator keyGenerat | |||
| return (T) config.get(); | |||
| } | |||
|
|
|||
| public <T> void put(String version,String url,String name,ReferenceConfig<T> referenceConfig){ | |||
| if(StringUtils.isBlank(version)){ | |||
There was a problem hiding this comment.
You need to format your code, check https://github.com/apache/incubator-dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml
|
Since we have not found a reasonable, easy-to-use way for ReferenceConfigCache, we'll close this PR firstly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix the issue #1293
Brief changelog
add the method of getting whether the cache exists
add the method of putting key and ReferenceConfig
add a new method of getting ReferenceConfig through url,name,version
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.