-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo #3714
[Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo #3714
Conversation
I have run the unit test, and write a demo to test the new module |
Codecov Report
@@ Coverage Diff @@
## master #3714 +/- ##
============================================
- Coverage 63.67% 63.62% -0.06%
Complexity 71 71
============================================
Files 709 712 +3
Lines 31378 31443 +65
Branches 5071 5072 +1
============================================
+ Hits 19981 20005 +24
- Misses 9105 9141 +36
- Partials 2292 2297 +5
Continue to review full report at Codecov.
|
348f22b
to
151d56b
Compare
Sorry, there is some conflict, I think it is due to the avro serialization has been merged. Could you please resolve the conflict? |
OK, I will resolve the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the pull request.
What is the purpose of the change
#3707
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.