Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo #3714

Merged
merged 6 commits into from
Apr 16, 2019

Conversation

tswstarplanet
Copy link
Contributor

@tswstarplanet tswstarplanet commented Mar 21, 2019

What is the purpose of the change

#3707

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@tswstarplanet tswstarplanet changed the title Merge dubbo-serialization-gson into incubator-dubbo [Dubbo-3708]Merge dubbo-serialization-gson into incubator-dubbo Mar 21, 2019
@tswstarplanet
Copy link
Contributor Author

I have run the unit test, and write a demo to test the new module

@tswstarplanet tswstarplanet changed the title [Dubbo-3708]Merge dubbo-serialization-gson into incubator-dubbo [Dubbo-3707]Merge dubbo-serialization-gson into incubator-dubbo Mar 21, 2019
@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #3714 into master will decrease coverage by 0.05%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3714      +/-   ##
============================================
- Coverage     63.67%   63.62%   -0.06%     
  Complexity       71       71              
============================================
  Files           709      712       +3     
  Lines         31378    31443      +65     
  Branches       5071     5072       +1     
============================================
+ Hits          19981    20005      +24     
- Misses         9105     9141      +36     
- Partials       2292     2297       +5
Impacted Files Coverage Δ Complexity Δ
...dubbo/common/serialize/gson/GsonSerialization.java 100% <100%> (ø) 0 <0> (?)
...bo/common/serialize/gson/GsonJsonObjectOutput.java 100% <100%> (ø) 0 <0> (?)
...bbo/common/serialize/gson/GsonJsonObjectInput.java 80% <80%> (ø) 0 <0> (?)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 72.78% <0%> (-3.41%) 0% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1706807...d5884f2. Read the comment docs.

@tswstarplanet tswstarplanet requested a review from ralf0131 March 22, 2019 10:14
@ralf0131 ralf0131 changed the title [Dubbo-3707]Merge dubbo-serialization-gson into incubator-dubbo [Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo Mar 23, 2019
@tswstarplanet tswstarplanet force-pushed the dubbo-serialization-gson branch from 348f22b to 151d56b Compare March 28, 2019 16:02
@ralf0131
Copy link
Contributor

ralf0131 commented Apr 9, 2019

Sorry, there is some conflict, I think it is due to the avro serialization has been merged. Could you please resolve the conflict?

@tswstarplanet
Copy link
Contributor Author

Sorry, there is some conflict, I think it is due to the avro serialization has been merged. Could you please resolve the conflict?

OK, I will resolve the conflict.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants