fix register config not take effect because of url simplified #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beiwei30
approved these changes
Jul 17, 2019
beiwei30
reviewed
Jul 17, 2019
...dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
Outdated
Show resolved
Hide resolved
|
@imsunv Can you remove unused import sentence ? |
|
@cvictory ok |
imsunv
force-pushed
the
fix_url_register_config
branch
from
f5fa418 to
9498ad4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4397 +/- ##
============================================
+ Coverage 63.96% 63.97% +0.01%
Complexity 452 452
============================================
Files 769 769
Lines 33206 33206
Branches 5237 5237
============================================
+ Hits 21239 21244 +5
+ Misses 9546 9543 -3
+ Partials 2421 2419 -2
Continue to review full report at Codecov.
|
cvictory
reviewed
Sep 11, 2019
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.dubbo.registry.integration; |
imsunv
force-pushed
the
fix_url_register_config
branch
6 times, most recently
from
5b17fc2 to
cbb30ac
Compare
|
@cvictory RegistryDirectory in master Line separator is CRLF, it will change to LF when committing |
imsunv
force-pushed
the
fix_url_register_config
branch
from
cbb30ac to
b905448
Compare
|
fixed it by keep Line separator with CRLF |
|
@beiwei30 already fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4341
when set dubbo.registry.simplified true. the dubbo.service.register won't take effect because of the register key was simplified and will use default value true;
boolean register = registeredProviderUrl.getParameter("register", true);
change providerUrl here