Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4716] Fix judgment ipv4 address #4729

Merged
merged 6 commits into from
Aug 7, 2019
Merged

[Dubbo-4716] Fix judgment ipv4 address #4729

merged 6 commits into from
Aug 7, 2019

Conversation

kaori-seasons
Copy link

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #4729 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4729      +/-   ##
============================================
- Coverage     63.93%   63.92%   -0.01%     
+ Complexity      451      450       -1     
============================================
  Files           769      769              
  Lines         33160    33179      +19     
  Branches       5226     5229       +3     
============================================
+ Hits          21200    21210      +10     
- Misses         9543     9547       +4     
- Partials       2417     2422       +5
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (ø) 0 <0> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...ava/org/apache/dubbo/config/ApplicationConfig.java 88.33% <0%> (-2.9%) 0% <0%> (ø)
...ava/org/apache/dubbo/common/utils/StringUtils.java 84.01% <0%> (-0.84%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (-0.63%) 29% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 82.69% <0%> (ø) 0% <0%> (ø) ⬇️
...ubbo/metadata/store/redis/RedisMetadataReport.java 55.55% <0%> (+1.26%) 6% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1173b40...1aacfb4. Read the comment docs.

@htynkn
Copy link
Member

htynkn commented Aug 4, 2019

Could you please provide some detail for this PR?

@kaori-seasons
Copy link
Author

kaori-seasons commented Aug 5, 2019

Could you please provide some detail for this PR?

@htynkn ,These two commits are

@kaori-seasons kaori-seasons changed the title Fix judgment ipv4 address [Dubbo-4716] [Dubbo-4712] Fix judgment ipv4 address and fix the classloader of the MetadataReportService Aug 5, 2019
@kaori-seasons kaori-seasons changed the title [Dubbo-4716] [Dubbo-4712] Fix judgment ipv4 address and fix the classloader of the MetadataReportService [Dubbo-4716] Fix judgment ipv4 address Aug 5, 2019
Fix to [#4712](#4712) and Replace the context loader
@tswstarplanet
Copy link
Contributor

Your repository seems not clean. Please follow the steps in CONTRIBUTING.md

@kaori-seasons
Copy link
Author

Your repository seems not clean. Please follow the steps in CONTRIBUTING.md

Your repository seems not clean. Please follow the steps in CONTRIBUTING.md

@tswstarplanet
Hello, I have emptied the extra files

@tswstarplanet
Copy link
Contributor

LGTM

@tswstarplanet tswstarplanet merged commit 1bcd921 into apache:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants