-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize logic of DubboBeanDefinitionParser.java #4770
Optimize logic of DubboBeanDefinitionParser.java #4770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -389,9 +381,10 @@ private static void parseArguments(String id, NodeList nodeList, RootBeanDefinit | |||
} | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are two more lines here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra spaces
...ig-spring/src/main/java/org/apache/dubbo/config/spring/schema/DubboBeanDefinitionParser.java
Show resolved
Hide resolved
there is one problem, i will commit again |
e6476a6
to
619ccfc
Compare
It's ok |
Codecov Report
@@ Coverage Diff @@
## master #4770 +/- ##
============================================
- Coverage 63.96% 63.93% -0.04%
+ Complexity 452 451 -1
============================================
Files 769 769
Lines 33179 33167 -12
Branches 5229 5227 -2
============================================
- Hits 21222 21204 -18
- Misses 9540 9542 +2
- Partials 2417 2421 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4770 +/- ##
============================================
- Coverage 64.02% 63.93% -0.10%
+ Complexity 452 451 -1
============================================
Files 769 769
Lines 33179 33167 -12
Branches 5229 5227 -2
============================================
- Hits 21243 21204 -39
- Misses 9518 9542 +24
- Partials 2418 2421 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What is the purpose of the change
Make code of process callback of method cleaner in DubboBeanDefinitionParser
Brief changelog
DubboBeanDefinitionParser.java
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.