Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize logic of DubboBeanDefinitionParser.java #4770

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

tswstarplanet
Copy link
Contributor

What is the purpose of the change

Make code of process callback of method cleaner in DubboBeanDefinitionParser

Brief changelog

DubboBeanDefinitionParser.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@tswstarplanet tswstarplanet changed the title Make code of DubboBeanDefinitionParser cleaner Optimize logic of DubboBeanDefinitionParser.java Aug 7, 2019
Copy link
Contributor

@lixiaojiee lixiaojiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -389,9 +381,10 @@ private static void parseArguments(String id, NodeList nodeList, RootBeanDefinit
}
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are two more lines here.

Copy link

@kaori-seasons kaori-seasons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra spaces

@tswstarplanet
Copy link
Contributor Author

there is one problem, i will commit again

@tswstarplanet tswstarplanet force-pushed the dubbo_bean_parse_method branch from e6476a6 to 619ccfc Compare August 8, 2019 05:14
@tswstarplanet
Copy link
Contributor Author

there is one problem, i will commit again

It's ok

@codecov-io
Copy link

Codecov Report

Merging #4770 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4770      +/-   ##
============================================
- Coverage     63.96%   63.93%   -0.04%     
+ Complexity      452      451       -1     
============================================
  Files           769      769              
  Lines         33179    33167      -12     
  Branches       5229     5227       -2     
============================================
- Hits          21222    21204      -18     
- Misses         9540     9542       +2     
- Partials       2417     2421       +4
Impacted Files Coverage Δ Complexity Δ
...onfig/spring/schema/DubboBeanDefinitionParser.java 65.86% <100%> (-1.87%) 0 <0> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 64.75% <0%> (-2.46%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.58% <0%> (-0.37%) 0% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bcd921...619ccfc. Read the comment docs.

Copy link
Contributor

@lixiaojiee lixiaojiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lixiaojiee lixiaojiee merged commit b0064d7 into apache:master Aug 10, 2019
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.93%. Comparing base (1bcd921) to head (619ccfc).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4770      +/-   ##
============================================
- Coverage     64.02%   63.93%   -0.10%     
+ Complexity      452      451       -1     
============================================
  Files           769      769              
  Lines         33179    33167      -12     
  Branches       5229     5227       -2     
============================================
- Hits          21243    21204      -39     
- Misses         9518     9542      +24     
- Partials       2418     2421       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants