Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code #4885

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Remove redundant code #4885

merged 3 commits into from
Aug 21, 2019

Conversation

thelproad
Copy link
Contributor

Remove redundant code.

@codecov-io
Copy link

Codecov Report

Merging #4885 into master will decrease coverage by 0.16%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4885      +/-   ##
============================================
- Coverage     63.99%   63.83%   -0.17%     
+ Complexity      451      448       -3     
============================================
  Files           769      769              
  Lines         33161    33125      -36     
  Branches       5230     5204      -26     
============================================
- Hits          21221    21144      -77     
- Misses         9522     9561      +39     
- Partials       2418     2420       +2
Impacted Files Coverage Δ Complexity Δ
...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java 69.69% <ø> (-1.74%) 0 <0> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 83.45% <100%> (+2.57%) 0 <0> (ø) ⬇️
...ubbo/rpc/protocol/nativethrift/ThriftProtocol.java 71.79% <50%> (-0.71%) 8 <0> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 37.5% <0%> (-50%) 0% <0%> (ø)
...g/apache/dubbo/rpc/protocol/http/HttpProtocol.java 46.03% <0%> (-21.83%) 6% <0%> (-5%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80% <0%> (-7.5%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a025cc1...d3e7b3b. Read the comment docs.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beiwei30 beiwei30 merged commit c0be402 into apache:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants