Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4984]Fix: type definition for String class #5032

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

Moriadry-zz
Copy link

What is the purpose of the change

Fix #4984

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #5032 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5032      +/-   ##
============================================
- Coverage     63.95%   63.95%   -0.01%     
- Complexity      451      452       +1     
============================================
  Files           769      769              
  Lines         33182    33184       +2     
  Branches       5232     5233       +1     
============================================
  Hits          21222    21222              
- Misses         9541     9543       +2     
  Partials       2419     2419
Impacted Files Coverage Δ Complexity Δ
...bbo/metadata/definition/TypeDefinitionBuilder.java 93.1% <100%> (+0.51%) 0 <0> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 63.63% <0%> (-1.14%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (-0.63%) 29% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.21% <0%> (+3.57%) 9% <0%> (+1%) ⬆️
...mmon/threadpool/support/AbortPolicyWithReport.java 89.18% <0%> (+5.4%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c536eec...38bf364. Read the comment docs.

@htynkn htynkn requested a review from lexburner September 13, 2019 08:06
@htynkn
Copy link
Member

htynkn commented Sep 13, 2019

@lexburner This is PR for #4984, could you help on reviewing it?

@lexburner
Copy link
Contributor

LGTM

@lexburner lexburner merged commit dbb0a64 into apache:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type 'java.lang.String' in metadata shouldn't include internal type.
5 participants