Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4331] Improve api doc #4331 #5070

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Conversation

sonymoon
Copy link
Contributor

What is the purpose of the change

fix #4331

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@sonymoon
Copy link
Contributor Author

This should work: ./mvnw clean javadoc:aggregate -Dmaven.javadoc.skip=false -Prelease in my local OS. Just need a profile specified and some plugin configurations.

@sonymoon
Copy link
Contributor Author

INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  07:18 min
[INFO] Finished at: 2019-09-16T11:36:35Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.0:testCompile (default-testCompile) on project dubbo-rpc-dubbo: Compilation failure
[ERROR] error: error reading /home/travis/.m2/repository/org/glassfish/javax.el/3.0.1-b08/javax.el-3.0.1-b08.jar; error in opening zip file
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :dubbo-rpc-dubbo
/home/travis/.travis/functions: line 537:  4348 Terminated              travis_jigger "${!}" "${timeout}" "${cmd[@]}"
travis_time:end:06a84ff2:start=1568633355964402712,finish=1568633795937931705,duration=439973528993,event=script
�[0K�[31;1mThe command "travis_wait 30 ./mvnw --batch-mode --no-transfer-progress clean install -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true" exited with 1.�[0m

CI Failed. Not related to this PR.

@sonymoon
Copy link
Contributor Author

Could someone re-trigger CI test ? ping @chickenlj @cvictory

@sonymoon
Copy link
Contributor Author

I would be very appreciated if you help review @htynkn.

2. doc title is using dubbo-parent, should be Apache Dubbo
Fixs apache#4331
@codecov-io
Copy link

Codecov Report

Merging #5070 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5070      +/-   ##
============================================
- Coverage     64.01%   63.98%   -0.04%     
- Complexity      451      452       +1     
============================================
  Files           769      769              
  Lines         33246    33246              
  Branches       5246     5246              
============================================
- Hits          21284    21273      -11     
- Misses         9530     9546      +16     
+ Partials       2432     2427       -5
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 65.85% <0%> (-17.08%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-3.07%) 0% <0%> (ø)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 56.47% <0%> (-2.36%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.77% <0%> (+1.13%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 83.33% <0%> (+3.33%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 60.22% <0%> (+4.54%) 21% <0%> (+1%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 85.36% <0%> (+4.87%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53624e...ccade13. Read the comment docs.

@htynkn
Copy link
Member

htynkn commented Sep 18, 2019

What maven command should use with this change?
I try ./mvnw clean javadoc:aggregate -Dmaven.javadoc.skip=false somehow those changes can't apply to javadoc

@sonymoon
Copy link
Contributor Author

What maven command should use with this change?
I try ./mvnw clean javadoc:aggregate -Dmaven.javadoc.skip=false somehow those changes can't apply to javadoc

./mvnw clean javadoc:aggregate -Dmaven.javadoc.skip=false -Prelease .
-P release is required because the javadoc maven plugin is configured under profile release
@htynkn

Copy link
Member

@htynkn htynkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@htynkn htynkn merged commit 46486bb into apache:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API-DOC] Improve api doc
3 participants