-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-4331] Improve api doc #4331 #5070
Conversation
This should work: |
874de78
to
04b209f
Compare
CI Failed. Not related to this PR. |
04b209f
to
0f2e304
Compare
Could someone re-trigger CI test ? ping @chickenlj @cvictory |
I would be very appreciated if you help review @htynkn. |
0f2e304
to
51a3ec2
Compare
2. doc title is using dubbo-parent, should be Apache Dubbo Fixs apache#4331
51a3ec2
to
ccade13
Compare
Codecov Report
@@ Coverage Diff @@
## master #5070 +/- ##
============================================
- Coverage 64.01% 63.98% -0.04%
- Complexity 451 452 +1
============================================
Files 769 769
Lines 33246 33246
Branches 5246 5246
============================================
- Hits 21284 21273 -11
- Misses 9530 9546 +16
+ Partials 2432 2427 -5
Continue to review full report at Codecov.
|
What maven command should use with this change? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution
What is the purpose of the change
fix #4331
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.