Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复 CollectionUtils类toStringMap方法没有检查 pairs 参数是否为空. #5102

Merged
merged 2 commits into from
Sep 22, 2019
Merged

修复 CollectionUtils类toStringMap方法没有检查 pairs 参数是否为空. #5102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bda377
修复 CollectionUtils类toStringMap方法没有检查 pairs 参数是否为空.
xiaoheng1 Sep 22, 2019
cdaf4dd
使用 ArrayUtils#isEmpty 方法检查 pairs 参数是否为空.
xiaoheng1 Sep 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dubbo-common/src/main/java/org/apache/dubbo/common/utils/CollectionUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ private static boolean objectEquals(Object obj1, Object obj2) {

public static Map<String, String> toStringMap(String... pairs) {
Map<String, String> parameters = new HashMap<>();
if(ArrayUtils.isEmpty(pairs)){
return parameters;
}

if (pairs.length > 0) {
if (pairs.length % 2 != 0) {
throw new IllegalArgumentException("pairs must be even.");
Expand Down