Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 #23

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

fredbalves86
Copy link
Contributor

Bumping guava version to 32.0.1-jre to fix CVE-2023-2976

@fredbalves86 fredbalves86 changed the title Guava version 32.0.1 bump Guava version 32.0.1 bump to fix 960c91f Jul 6, 2023
@fredbalves86 fredbalves86 changed the title Guava version 32.0.1 bump to fix 960c91f Guava version 32.0.1 bump to fix CVE-2023-2976 Jul 6, 2023
@fredbalves86
Copy link
Contributor Author

@jojochuang Can this be done?

This is the only dependency of hadoop-common that still has guava 31.1-jre

@jojochuang jojochuang changed the title Guava version 32.0.1 bump to fix CVE-2023-2976 HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 Aug 8, 2023
Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the version in LICENSE-binary?

Created a jira to track this task.

This is the list of dependencies after the change:

[INFO] org.apache.hadoop.thirdparty:hadoop-shaded-guava:jar:1.2.0-SNAPSHOT
[INFO] - com.google.guava:guava:jar:32.0.1-jre:compile
[INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] +- org.checkerframework:checker-qual:jar:3.33.0:compile
[INFO] +- com.google.errorprone:error_prone_annotations:jar:2.18.0:compile
[INFO] - com.google.j2objc:j2objc-annotations:jar:2.8:compile

@jojochuang
Copy link
Contributor

We'd also need to release a new hadoop-thirdparty version so the main hadoop repo can use.

@fredbalves86
Copy link
Contributor Author

@jojochuang Done.

@Killianoc
Copy link

Hi @jojochuang @fredbalves86, will this be available in a new release soon out of curiosity?

@steveloughran
Copy link
Contributor

  1. is this ready to go in?
  2. can we get the parquet update in too, at which point we can/should push out a new release -though that won't be a drop-in replacement JAR, will it?
  3. of course, we need to qualify the upgrade

@Killianoc no schedule

@fredbalves86
Copy link
Contributor Author

@jojochuang any ETA on this?

@LorenzoMartini
Copy link

Is there any movement here?

@smitagarg1
Copy link

Is is getting merged anytime soon ?

@steveloughran
Copy link
Contributor

I've hit the approve and run button to see what the ci builds say. if things are good I'll merge

@Grimoren
Copy link

I've hit the approve and run button to see what the ci builds say. if things are good I'll merge

Any chance you could merge this soon. Got a CVE reporting against hadoop-shaded-guava.

@coheigea coheigea mentioned this pull request Oct 18, 2023
@fredbalves86
Copy link
Contributor Author

I've hit the approve and run button to see what the ci builds say. if things are good I'll merge

@steveloughran any chance of this being merger and new version released soon?

@steveloughran
Copy link
Contributor

ok, let's merge

@fredbalves86 what name do you want to use for credit in the commit message?
+what apache jira account is yours to assign the work to?

@fredbalves86
Copy link
Contributor Author

ok, let's merge

@fredbalves86 what name do you want to use for credit in the commit message? +what apache jira account is yours to assign the work to?

You can use Frederico Alves

I don't have an apache jira account

@steveloughran steveloughran merged commit 52c38fe into apache:trunk Nov 3, 2023
@steveloughran
Copy link
Contributor

done. mukund has been looking at doing a new 3.3.x release...we should get this out first

@fredbalves86 fredbalves86 deleted the guava_version_32.0.1_bump branch November 6, 2023 15:29
@saeidN
Copy link

saeidN commented Jan 10, 2024

@steveloughran when will mvn repo be updated with the new jar?

@steveloughran
Copy link
Contributor

new release is out; 3.4.0 RC2 will ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants