-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) #3369
Comments
Thanks! Do you mind making a PR with this change? |
JWT007
added a commit
to JWT007/logging-log4j2
that referenced
this issue
Jan 7, 2025
…der (apache#3369) Deprecated LoggerConfig.RootLogger.Builder#withtFilter(Filter). Added LoggerConfig.RoottLogger.Builder#withFilter(Filtter)
JWT007
added a commit
to JWT007/logging-log4j2
that referenced
this issue
Jan 8, 2025
@ppkarwasz - made quick change - PR workflow awaiting approval: |
JWT007
pushed a commit
to JWT007/logging-log4j2
that referenced
this issue
Feb 11, 2025
+ properly delegated from deprecated method to new method + updated affected package-info versions for baseline
@ppkarwasz - it took me a while but I added tthe change log entry for 2.25.0 I also fixed spotless problem and updated package versions for baseline |
JWT007
pushed a commit
to JWT007/logging-log4j2
that referenced
this issue
Feb 16, 2025
* switched tests to use Builders instead of createLogger * changed new LoggerConig.RootLogger.Builder#withFilter to LoggerConfig.RootLogger.Builder#setFilter * deprecated LoggerConfig.Builder.withFilter and added LoggerConig.Builder.setFilter * moved changelog to correct .2.x.x directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Log4j 2.24
In LoggerConfig.Builder, an original typo existed in the '
withtFilter
' method (extra 't' in name).This was fixed by deprecating the original method and adding the correct 'withFilter' method.
However, it was not fixed in the nested
LoggerConfig.RootLogger.Builder
implementation - there the name is still incorrect.The nested builder method should also be deprecated and '
withFilter
' added to replace it with the correct name.The text was updated successfully, but these errors were encountered: