Move to Java17 #438
Closed
Move to Java17 #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmannibucau
approved these changes
Mar 10, 2024
| import org.eclipse.aether.spi.connector.transport.PeekTask; | ||
| import org.eclipse.aether.spi.connector.transport.PutTask; | ||
| import org.eclipse.aether.spi.connector.transport.TransportTask; | ||
| import org.eclipse.aether.spi.connector.transport.*; |
slawekjaranowski
approved these changes
Mar 10, 2024
michael-o
requested changes
Mar 12, 2024
| <name>Maven Artifact Resolver Transport JDK 11</name> | ||
| <description>Maven Artifact Transport JDK Java 11+.</description> | ||
| <name>Maven Artifact Resolver Transport JDK 17</name> | ||
| <description>Maven Artifact Transport JDK Java 17+.</description> |
There was a problem hiding this comment.
Why? Can't it then just be "Maven Artifact Resolver Transport JDK" or so?
| | 92. | `"aether.transport.jdk.httpVersion"` | `java.lang.String` | Use string representation of HttpClient version enum "HTTP_2" or "HTTP_1_1" to set default HTTP protocol to use. | `"HTTP_2"` | 2.0.0 | Yes | Session Configuration | | ||
| | 93. | `"aether.transport.jdk.maxConcurrentRequests"` | `java.lang.Integer` | The hard limit of maximum concurrent requests JDK transport can do. This is a workaround for the fact, that in HTTP/2 mode, JDK HttpClient initializes this value to Integer.MAX_VALUE (!) and lowers it on first response from the remote server (but it may be too late). See JDK bug <a href="https://bugs.openjdk.org/browse/JDK-8225647">JDK-8225647</a> for details. | `100` | 2.0.0 | Yes | Session Configuration | | ||
| | 92. | `"aether.transport.jdk.httpVersion"` | `String` | Use string representation of HttpClient version enum "HTTP_2" or "HTTP_1_1" to set default HTTP protocol to use. | `"HTTP_2"` | 2.0.0 | Yes | Session Configuration | | ||
| | 93. | `"aether.transport.jdk.maxConcurrentRequests"` | `Integer` | The hard limit of maximum concurrent requests JDK transport can do. This is a workaround for the fact, that in HTTP/2 mode, JDK HttpClient initializes this value to Integer.MAX_VALUE (!) and lowers it on first response from the remote server (but it may be too late). See JDK bug <a href="https://bugs.openjdk.org/browse/JDK-8225647">JDK-8225647</a> for details. | `100` | 2.0.0 | Yes | Session Configuration | |
There was a problem hiding this comment.
This does not make sense if the other references are still fully qualified and I would leave it fully qualified for consistency.
|
A JIRA issue is also advised. |
slachiewicz
approved these changes
Dec 15, 2024
|
I think this is obdolete since project is now on java 21? |
elharo
added
the
waiting-for-feedback
This is runtime requirement, not build time |
|
This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days. |
|
@cstamas Maybe worth cleaning up artefacts before Maven4? |
github-actions
bot
removed
waiting-for-feedback
|
Will happen in resolver 2.1 |
Shouldn't this happen with 3.0 and a namespace change for Maven 4/5? |
|
Or that, yes: point in point: not in 2.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: