-
Notifications
You must be signed in to change notification settings - Fork 165
[API]Add Order Async Send API(C) and example #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Win32/COrderlyAsyncProducer.vcxproj
Outdated
@@ -0,0 +1,117 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if Win32/COrderlyAsyncProducer.vcxproj and Win32/rocketmq-client-cpp.sln need merge to master ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you on this issue. Such configuration files shouldn't be merge into master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,remove middle-time file will make pure commit,we can do this
Win32/COrderlyAsyncProducer.vcxproj
Outdated
@@ -0,0 +1,117 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why we should push such configuration file of a tool.
Also Win32/rocketmq-client-cpp.sln
below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,all existed generated file could be removed,it cleaner
Could you please resolve the conflicts? |
tab space settings lead to conflict.it' solved already. |
defaultMQProducer->send(*message, | ||
&selectMessageQueue, arg,cSendCallback); | ||
} catch (exception &e) { | ||
printf("%s\n",e.what()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to remove the standard output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to remove the standard output.
yes,log the detail is better -:)
What is the purpose of the change
Add Order Async Send API(C) and example
Brief changelog
Add Order Async Send API(C) and example
Verifying this change
example run success
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.