Skip to content

[API]Add Order Async Send API(C) and example #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2019

Conversation

hugoasdf
Copy link
Contributor

@hugoasdf hugoasdf commented Mar 3, 2019

What is the purpose of the change

Add Order Async Send API(C) and example

Brief changelog

Add Order Async Send API(C) and example

Verifying this change

example run success

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@@ -0,0 +1,117 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if Win32/COrderlyAsyncProducer.vcxproj and Win32/rocketmq-client-cpp.sln need merge to master ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you on this issue. Such configuration files shouldn't be merge into master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,remove middle-time file will make pure commit,we can do this

@@ -0,0 +1,117 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we should push such configuration file of a tool.
Also Win32/rocketmq-client-cpp.sln below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,all existed generated file could be removed,it cleaner

@ShannonDing
Copy link
Member

Could you please resolve the conflicts?

@hugoasdf
Copy link
Contributor Author

tab space settings lead to conflict.it' solved already.

defaultMQProducer->send(*message,
&selectMessageQueue, arg,cSendCallback);
} catch (exception &e) {
printf("%s\n",e.what());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to remove the standard output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to remove the standard output.

yes,log the detail is better -:)

@ShannonDing ShannonDing merged commit c7e7508 into apache:master Apr 3, 2019
@ShannonDing ShannonDing added this to the 1.2.2 milestone Apr 3, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants