Skip to content

Format project with clang-format Chromium #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Format project with clang-format Chromium #131

merged 2 commits into from
Apr 11, 2019

Conversation

jonnxu
Copy link
Contributor

@jonnxu jonnxu commented Apr 9, 2019

What is the purpose of the change

Format project with clang-format Chromium

Brief changelog

all cpp and h files

clang-format:
{ BasedOnStyle: Chromium, ColumnLimit: 120, TabWidth: 2 }

Verifying this change

################## test start ###########
BatchMessageTest success
big_endianTest success
ClientRemotingProcessorTest success
ClientRPCHookTest success
CMessageExtTest success
CMessageTest success
CommandHeaderTest success
ConsumerRunningInfoTest success
CProducerTest success
CPullConsumerTest success
CPushConsumerTest success
HeartbeatDataTest success
KVTableTest success
LockBatchBodyTest success
MemoryBlockTest success
MemoryOutputStreamTest success
MessageQueueTest success
MQDecoderTest success
MQMessageExtTest success
MQMessageIdTest success
MQMessageQueueTest success
MQMessageTest success
NamesrvConfigTest success
PermNametTest success
ProcessQueueInfoTest success
PullSysFlagTest success
RemotingCommandTest success
ResponseFutureTest success
SocketUtilTest success
StringIdMakerTest success
TopicConfigTest success
TopicRouteDataTest success
UrlTest success
ValidatorsTest success
VirtualEnvUtilTest success
################## test end ###########

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 9b239c9 into apache:master Apr 11, 2019
@jonnxu jonnxu deleted the project-format branch July 24, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants