Skip to content

fix bug: encode batch in header #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix bug: encode batch in header #151

wants to merge 1 commit into from

Conversation

yichenluan
Copy link

What is the purpose of the change

Fix a bug:
take out comment on encode batch to header

Brief changelog

fix bug: encode batch in header

Verifying this change

build and test

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@yichenluan
Copy link
Author

This is a serious bug, please merge it ASAP.

@ShannonDing @ifplusor

@jonnxu
Copy link
Contributor

jonnxu commented Jun 3, 2019

modify not correct, reference to #152

@yichenluan
Copy link
Author

In practice, "batch" in requestMap is unnecessary

@jonnxu jonnxu added the duplicate This issue or pull request already exists label Jul 8, 2019
@ShannonDing
Copy link
Member

close it due to duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants