Skip to content

fix(send): try to use command v2 to send messages #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 11, 2020

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

[fix #189] fix(send): try to use command v2 to send messages

@ShannonDing ShannonDing added bug Something isn't working enhancement New feature or request labels Jan 11, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 11, 2020
@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #225 into master will increase coverage by 0.86%.
The diff coverage is 98.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   51.01%   51.88%   +0.86%     
==========================================
  Files         173      174       +1     
  Lines       10701    10857     +156     
==========================================
+ Hits         5459     5633     +174     
+ Misses       5242     5224      -18
Impacted Files Coverage Δ
src/common/AsyncCallbackWrap.cpp 9.58% <ø> (ø) ⬆️
src/common/AsyncCallbackWrap.h 33.33% <ø> (ø) ⬆️
src/MQClientFactory.cpp 18.45% <0%> (ø) ⬆️
src/producer/DefaultMQProducer.cpp 5.46% <0%> (-0.02%) ⬇️
src/MQClientAPIImpl.cpp 16.49% <100%> (+0.35%) ⬆️
test/src/protocol/CommandHeaderTest.cpp 100% <100%> (ø) ⬆️
test/src/common/MQVersionTest.cpp 100% <100%> (ø)
src/protocol/CommandHeader.h 76.82% <100%> (+6.06%) ⬆️
src/common/MQVersion.cpp 100% <100%> (+100%) ⬆️
src/common/VirtualEnvUtil.cpp 100% <100%> (+100%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a3878...8ce4bd5. Read the comment docs.

@ShannonDing ShannonDing merged commit b50d99c into apache:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The feature of send MessageBatch is error.
2 participants