Skip to content

feat(memory): add asan/lsan support, and formatting code. #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2020

Conversation

WoodsCumming
Copy link
Contributor

@WoodsCumming WoodsCumming commented Feb 23, 2020

What is the purpose of the change

(1)Declare variables explicitly, and clarify variable types.
(2)Format the code style.
(3)Add asan support for memory address out of range checking.
(4)Add lsan support for memory leak checking.
(5)Simplify redirection semantics for easy understanding

Brief changelog

Add asan/lsan support, and formatting code.

Verifying this change

Has verified. Want a code review.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

(1)Declare variables explicitly, and clarify variable types.
(2)Format the code style.
(3)Add asan support for memory address out of range checking.
(4)Add lsan support for memory leak checking.
@codecov-io
Copy link

codecov-io commented Feb 23, 2020

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   57.69%   57.69%           
=======================================
  Files         182      182           
  Lines       11652    11652           
=======================================
  Hits         6723     6723           
  Misses       4929     4929

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7d173...bdf44a9. Read the comment docs.

@WoodsCumming WoodsCumming changed the title Modification item: Add asan/lsan support, and formatting code. Feb 23, 2020
@ShannonDing ShannonDing added the enhancement New feature or request label Feb 24, 2020
@ShannonDing ShannonDing changed the title Add asan/lsan support, and formatting code. feat(memory): add asan/lsan support, and formatting code. Feb 24, 2020
@ShannonDing ShannonDing added this to the 2.0.1 milestone Feb 24, 2020
@ShannonDing ShannonDing merged commit 41d7c35 into apache:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants