feat(version): add api to get SDK versions #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 57.86% 58.41% +0.55%
==========================================
Files 182 182
Lines 11683 11769 +86
==========================================
+ Hits 6760 6875 +115
+ Misses 4923 4894 -29
Continue to review full report at Codecov.
|
vongosling
reviewed
Feb 26, 2020
vongosling
approved these changes
Feb 27, 2020
| #define ROCKETMQCPP_VERSION "2.0.0" | ||
| #define BUILD_DATE "02-14-2020" | ||
| #define BUILD_DATE "22:50:18 02-14-2020" |
There was a problem hiding this comment.
ToDo, hope to be fixed in the near long time.
| void DefaultMQProducerImpl::logConfigs() { | ||
| showClientConfigs(); | ||
|
|
||
| LOG_WARN("SendMsgTimeout:%d ms", m_sendMsgTimeout); |
There was a problem hiding this comment.
warn is not better for normal output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add api to get SDK versions
CPP API: version()
C API: ShowProducerVersion()... and so on.
you can get SDK version strings like this:
CPP CORE VERSION: 2.0.0, BUILD TIME: 19:30:30 02-14-2020Brief changelog
feat(version): add api to get SDK versions