Skip to content

Add name server domain support and refactor pull consumer. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2018
Merged

Add name server domain support and refactor pull consumer. #29

merged 2 commits into from
Dec 12, 2018

Conversation

ShannonDing
Copy link
Member

Add name server domain support and refactor pull consumer.

  1. add name server domain for the producer
  2. add name server domain for the push consumer
  3. add name server domain for the pull consumer
  4. fix crash error when getting the message queue list from the broker
  5. refactor pull messages from the broker
  6. update pull consumer example

@duhengforever
Copy link
Contributor

LGTM

wlliqipeng
wlliqipeng approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@wlliqipeng wlliqipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vongosling vongosling added the enhancement New feature or request label Dec 12, 2018
@vongosling vongosling added this to the 1.2.1 milestone Dec 12, 2018
@vongosling vongosling merged commit 643a638 into apache:master Dec 12, 2018
lizhanhui added a commit that referenced this pull request Oct 14, 2021
@lizhanhui
Adapt to protocol v1.0-alpha1 (#29)
332f2e8 
Adapt to protocol v1.0-alpha1, including the following changes
* Import latest protocol files
* Replace multiplex RPC with 3 separate RPCs, PollCommand, ReportThreadStackTrace, ReportMessageConsumptionVerificationResult
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vongosling vongosling vongosling approved these changes

@wlliqipeng wlliqipeng wlliqipeng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ShannonDing @duhengforever @vongosling @wlliqipeng