Skip to content

Fix warning while compiling rocketmq_static #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

Fix warning while compiling rocketmq_static #47

merged 1 commit into from
Jan 2, 2019

Conversation

stcai
Copy link
Contributor

@stcai stcai commented Jan 1, 2019

  1. the return value of "UtilAll::ReplaceFile" is bool, not integer.
  2. gcc suggest parentheses around '&&' within '||'。

@stcai
fix warning while compiling rocketmq_static
7e514f2 
1. the return value of "UtilAll::ReplaceFile" is bool, not integer.
2. gcc suggest parentheses around '&&' within '||'。
@ShannonDing ShannonDing added the enhancement New feature or request label Jan 2, 2019
@ShannonDing ShannonDing added this to the 1.2.1 milestone Jan 2, 2019
@ShannonDing ShannonDing merged commit 476a219 into apache:master Jan 2, 2019
@ShannonDing ShannonDing changed the title fix warning while compiling rocketmq_static Fix warning while compiling rocketmq_static Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stcai @ShannonDing